This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] Avoid warnings during bootstrap on arm-linux
On Mon, 10 Dec 2007, 02:32:16 +0100, Kaz Kojima wrote:
> Mark Mitchell <mark@codesourcery.com> wrote:
> > I think the fix for arm_size_return_regs should be to make the function
> > itself return unsigned; it is, after all, returning a size. That may
> > require some casts elsewhere, of course.
>
> I've tried it and found no warnings with the revised one below.
> Ok for trunk?
>
> Regards,
> kaz
> --
> * config/arm/arm.c (arm_size_return_regs): Make return type
> unsigned.
Dunno if there are some common rules, but shouldn't we use "unsigned int"
here instead of plain "unsigned"?
> --- ORIG/trunk/gcc/config/arm/arm.c 2007-11-23 21:23:23.000000000 +0900
> +++ LOCAL/trunk/gcc/config/arm/arm.c 2007-12-10 09:52:33.000000000 +0900
> @@ -77,7 +77,7 @@ static bool thumb_force_lr_save (void);
> static unsigned long thumb1_compute_save_reg_mask (void);
> static int const_ok_for_op (HOST_WIDE_INT, enum rtx_code);
> static rtx emit_sfm (int, int);
> -static int arm_size_return_regs (void);
> +static unsigned arm_size_return_regs (void);
+static unsigned int arm_size_return_regs (void);
> static bool arm_assemble_integer (rtx, unsigned int, int);
> static const char *fp_const_from_val (REAL_VALUE_TYPE *);
> static arm_cc get_arm_condition_code (rtx);
> @@ -11801,7 +11801,7 @@ emit_multi_reg_push (unsigned long mask)
> }
>
> /* Calculate the size of the return value that is passed in registers. */
> -static int
> +static unsigned
+static unsigned int
> arm_size_return_regs (void)
> {
> enum machine_mode mode;
Cheers.
l8er
manfred