This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)

From: Tobias Burnus <burnus at net-b dot de>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: FX <fxcoudert at gmail dot com>, Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
Date: Sat, 08 Dec 2007 14:43:43 +0100
Subject: Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
References: <20071204150725.GB16835@devserv.devel.redhat.com> <4756C864.6040805@net-b.de> <84fc9c000712060254g79aaa6dfncc3a0c4a1f808632@mail.gmail.com> <20071206112837.GH25112@devserv.devel.redhat.com> <19c433eb0712060349n39a6b574i792ebb4cb2ac20db@mail.gmail.com> <20071206173416.GA13207@devserv.devel.redhat.com>

Jakub Jelinek wrote:
> Attached are two approaches.
> The second one calls the dbg hooks immediately during load_file, but moves
> the gfc_new_file call later on after debug hooks are initialized.
>
> The first one instead records the various file change events we want to
> pass to debug_hooks in a vector, with gfc_linebuf pointers showing what
> events should be reported at what line.
> [...]
> So, for stabs' sake I think the first approach is better, though of course
> the second approach is simpler.
>   
Let's go for the first approach then.

OK for the trunk. Can you also cite PR34359 in your commit?

Thanks for the fix,

Tobias

References:
- [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: Jakub Jelinek
- Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: Tobias Burnus
- Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: Richard Guenther
- Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: Jakub Jelinek
- Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: FX
- Re: [PATCH] Ensure start_source_file and end_source_file debug hook calls in gfortran always match (PR debug/33739)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]