This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR33713: remove -fforce-addr
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Rask Ingemann Lambertsen <rask at sygehus dot dk>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 7 Dec 2007 12:48:18 -0400
- Subject: Re: PR33713: remove -fforce-addr
- References: <20071129175051.GA12296@redhat.com> <20071207161821.GY17368@sygehus.dk>
> This breaks at least m32c-unknown-elf:
>
> make[2]: Entering directory `/home/rask/build/gcc-m32c-unknown-elf/gcc'
> gcc -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wmissing-format-attribute -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/rask/src/all/gcc -I/home/rask/src/all/gcc/. -I/home/rask/src/all/gcc/../include -I/home/rask/src/all/gcc/../libcpp/include -I/home/rask/src/all/gcc/../libdecnumber -I/home/rask/src/all/gcc/../libdecnumber/dpd -I../libdecnumber /home/rask/src/all/gcc/explow.c -o explow.o
> /home/rask/src/all/gcc/explow.c: In function memory_address:
> /home/rask/src/all/gcc/explow.c:448: error: label win used but not defined
m32c's LEGITIMIZE_ADDRESS is wrong. It should be using the WIN macro,
not jumping to "win" directly, especially since the "win" label is no
longer present.
LEGITIMIZE_RELOAD_ADDRESS suffers from the same problem even though it's
not causing any problems now.
I've fixed both, and committed as obvious.
Aldy
* m32c.h (LEGITIMIZE_ADDRESS): Use WIN instead of win.
(LEGITIMIZE_RELOAD_ADDRESS): Same.
--- config/m32c/m32c.h (revision 130686)
+++ config/m32c/m32c.h (local)
@@ -561,11 +561,11 @@ typedef struct m32c_cumulative_args
#define LEGITIMIZE_ADDRESS(X,OLDX,MODE,WIN) \
if (m32c_legitimize_address(&(X),OLDX,MODE)) \
- goto win;
+ goto WIN;
#define LEGITIMIZE_RELOAD_ADDRESS(X,MODE,OPNUM,TYPE,IND_LEVELS,WIN) \
if (m32c_legitimize_reload_address(&(X),MODE,OPNUM,TYPE,IND_LEVELS)) \
- goto win;
+ goto WIN;