This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] libffi: Fixes for MIPS n32 ABI.
- From: Richard Sandiford <rsandifo at nildram dot co dot uk>
- To: David Daney <ddaney at avtrex dot com>
- Cc: Java Patches <java-patches at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 01 Dec 2007 19:14:43 +0000
- Subject: Re: [Patch] libffi: Fixes for MIPS n32 ABI.
- References: <474E65AF.3040605@avtrex.com> <874pf2ty6c.fsf@firetop.home> <4751AB52.5070405@avtrex.com>
David Daney <ddaney@avtrex.com> writes:
> Richard Sandiford wrote:
>> ...you're talking about ffi_raw vs. _Jv_word, right?
>
> Correct.
>
>> As far as
>> reviewing the patch goes, I'll sign off on the former being 8 bytes
>> and the latter being 4,
>
> That was the state for n32 before the patch and the cause of the problems.
Right. Sorry for being ambiguous (twice in two days!). I meant:
I agree that the problem you describe exists for n32, and that it
needs to be fixed. (As far as I could tell, that was the only really
target-specific item of interest here, so I thought it was the only
reviewing input I was qualified to give.)
>> But why doesn't the ffi_java_raw_* API use a separate union that matches
>> the layout of _Jv_Word on all targets?
>
> That is what my new patch will do.
OK, great.
Richard