This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2][Modulo-sched] Fix the direction of the scheduling window


Revital1 Eres/Haifa/IBM wrote on 28/11/2007 10:55:06:

> Hello,
>
> Thanks for the comments.  Attached is the fixed version.
>
> > attachment "sms-3.c.txt":
> >
> > > /* { dg-do compile } */
> > > /* { dg-options "-O2 -fmodulo-sched -funroll-loops -dm" } */
> > >
> > > int X[100];
> > > int Y[100];
> > >
> > > int;
> > > foo (int len, long *result)
> > > {
> > >   int i;
> > >
> > >   len = 1000;
> > >   long res = *result;
> > >   for (i = 0; i < len; i++)
> > >     res += X[i] * Y[i];
> > >
> > >   *result = res;
> > > }>
> > >
> > > /* { dg-final { cleanup-rtl-dump "sms" } } */
> >
> > Better check that result is correct on some data, in addition to the
fact that
> > the loop is sms'ed.
>
> Done.
>
> Re-tested on powerpc64-linux and SPU together with patch 2/2.
> OK for mainline?
>

OK.
Just a typo: better call  foo (6, 3)  so that  res  will reach 601.

Ayal.


> Revital
>
> 2007-11-28  Ayal Zaks  <zaks@il.ibm.com>
>             Revital Eres  <eres@il.ibm.com>
>
>         * modulo-sched.c (get_sched_window): Fix the direction of the
>         scheduling window and add dump info.
>
> testsuite:
>
> 2007-11-27  Vladimir Yanovsky  <yanov@il.ibm.com>
>
>         * gcc.dg/sms-3.c: New testcase.
>

>
> [attachment "sms-3.c.txt" deleted by Ayal Zaks/Haifa/IBM] [attachment
> "patch_1_2_28.txt" deleted by Ayal Zaks/Haifa/IBM]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]