Re: [PATCH] PR34171

["Seongbae Park (박성배, 朴成培)" <seongbae dot park at gmail dot com>]

On Nov 28, 2007 10:20 PM, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> > 2007-11-28  Seongbae Park <seongbae.park@gmail.com>
> >
> >         PR rtl-optimization/34171
> >         * cfgrtl.c (update_bb_for_insn_chain): New function,
> >         refactored from update_bb_for_insn.
> >         (update_bb_for_insn): Call update_bb_for_insn.
> >         (rtl_merge_blocks, try_redirect_by_replacing_jump):
> >         Replace a loop with update_bb_for_insn_chain call.
> >         (cfg_layout_merge_blocks): Add a call to
> >         update_bb_for_insn_chain. Replace the for loop
> >         with a call to update_bb_for_insn_chain.
>
> I think it would make sense to use only inclusive bounds for
> update_bb_for_insn_chain, given that it is almost always invoked
> on NEXT_INSN (...).
>
> OK with this change if it is doable, thanks for fixing this.
>
> --
> Eric Botcazou

Attached is the updated patch, with the testcase from the PR.

Seongbae


gcc/testsuite/ChangeLog:

2007-10-29  Martin Michlmayr <tbm@cyrius.com>

        PR rtl-optimization/34171

        * gcc.dg/pr34171.c: New testcase.

gcc/ChangeLog:

2007-10-29  Seongbae Park <seongbae.park@gmail.com>

        PR rtl-optimization/34171

        * cfgrtl.c (update_bb_for_insn_chain): New function,
        refactored from update_bb_for_insn.
        (update_bb_for_insn): Call update_bb_for_insn.
        (rtl_merge_blocks, try_redirect_by_replacing_jump):
        Replace a loop with update_bb_for_insn_chain call.
        (cfg_layout_merge_blocks): Add a call to
        update_bb_for_insn_chain. Replace the for loop
        with a call to update_bb_for_insn_chain.

Attachment: pr34171-5.diff
Description: Text document