This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Handle OBJ_TYPE_REF in dump_expr (PR c++/34275)
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Mark Mitchell <mark at codesourcery dot com>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: 29 Nov 2007 19:14:49 -0600
- Subject: Re: [C++ PATCH] Handle OBJ_TYPE_REF in dump_expr (PR c++/34275)
- References: <20071129095759.GE16835@devserv.devel.redhat.com>
Jakub Jelinek <jakub@redhat.com> writes:
| Hi!
|
| OBJ_TYPE_REF isn't handled in dump_expr (well, it is, but only
| inside of CALL_EXPR).
|
| Ok for trunk?
|
| 2007-11-29 Jakub Jelinek <jakub@redhat.com>
|
| PR c++/34275
| * error.c (dump_expr): Handle OBJ_TYPE_REF.
|
| * g++.dg/other/error20.C: New test.
|
| --- gcc/cp/error.c.jj 2007-11-02 19:02:46.000000000 +0100
| +++ gcc/cp/error.c 2007-11-29 10:46:30.000000000 +0100
| @@ -2056,6 +2056,10 @@ dump_expr (tree t, int flags)
| pp_expression (cxx_pp, t);
| break;
|
| + case OBJ_TYPE_REF:
| + dump_expr (resolve_virtual_fun_from_obj_type_ref (t), flags);
| + break;
| +
OK, though I would prefer we stop adding to error.c, but use
cxx-pretty-print.c instead.
-- Gaby