This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR34171


On Nov 28, 2007 10:20 PM, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:
> > 2007-11-28  Seongbae Park <seongbae.park@gmail.com>
> >
> >         PR rtl-optimization/34171
> >         * cfgrtl.c (update_bb_for_insn_chain): New function,
> >         refactored from update_bb_for_insn.
> >         (update_bb_for_insn): Call update_bb_for_insn.
> >         (rtl_merge_blocks, try_redirect_by_replacing_jump):
> >         Replace a loop with update_bb_for_insn_chain call.
> >         (cfg_layout_merge_blocks): Add a call to
> >         update_bb_for_insn_chain. Replace the for loop
> >         with a call to update_bb_for_insn_chain.
>

Thanks for the quick review (especially considering not-so-informative
subject :)).

> I think it would make sense to use only inclusive bounds for
> update_bb_for_insn_chain, given that it is almost always invoked
> on NEXT_INSN (...).
>
> OK with this change if it is doable, thanks for fixing this.

It's certainly doable. I'll make the change and submit tomorrow. Thanks!
-- 
#pragma ident "Seongbae Park, compiler, http://seongbae.blogspot.com";


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]