This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tuples] dereference POINTER_PLUS_EXPR check

On 11/21/07 18:25, Richard Guenther wrote:

Previously we had an additional type available, the type of the result
of the P_P_E.

Right. This is not available anymore. The types of _EXPR trees on the RHS of assignments and/or conditionals is no longer available with the tuple representation.

What we checked is that the first argument of the PPE
is a pointer, that the second argument is convertible to sizetype and
that the first argument is convertible to the result type.

Yes, and we still check this.

With tuples the result type is now simply the type of the lhs of the
MODIFY_EXPR.

Yes.

Why do you think it doesn't make sense to look at the pointed-to types? 

Because - pointed-to types don't have anything to do with the type validity
of a P_P_E.

Yeah, good point. I was wrong in my initial analysis. The expression that we were failing to validate needed to have casts and I missed that.

Sorry for leading you down this rat hole, Aldy.


Diego.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]