This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR33396 - add --enable-intermodule for libgcc
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bernhard Fischer <rep dot dot dot nop at gmail dot com>
- Date: Tue, 20 Nov 2007 08:59:21 +0100
- Subject: Re: [PATCH] PR33396 - add --enable-intermodule for libgcc
- References: <20071119175146.GA1588@aon.at>
Bernhard Fischer wrote:
:ADDPATCH libgcc:
Hi,
The attached patch adds an optional IMA mode to libgcc's configury as
per PR33396. Included are some small fixes exposed by IMA. A few warnings
exposed by it are left unfixed for now, help on those is very welcome.
It is currently regtesting on i686-linux-gnu.
Nice work, but I want to be sure I understand it well before approving
the build parts (the others are pretty obvious but I cannot approve them).
First, here you have this:
libgcc-objects += $(lib2funcs-o)
+libgcc-onestep-sources += $(gcc_srcdir)/libgcc2.c
and later on, this:
+ifneq (@onestep@,)
+# add the rest
+libgcc-objects-onestep += $(libgcc-objects)
+endif
Does this mean that everything is included twice in libgcc? Also, isn't
the ifneq redundant? libgcc-objects-onestep should be unused if
@onestep@ is empty.
I am not sure what happens if you pass combine for many assembly source
codes, as in this:
+lib1asmfuncs_onestep.o: $(lib1asmfuncs-onestep-sources) \
+ $(lib1asmfuncs-onestep-prereq)
+ $(gcc_compile) $(lib1asmfuncs-onestep-defines) -xassembler-with-cpp \
+ -c $(gcc_srcdir)/config/$(LIB1ASMSRC) \
+ $(patsubst %,-include %,$(lib1asmfuncs-onestep-prereq)) -combine
Also, why are these commented?
+#libgcc-objects-onestep += $(lib1asmfuncs-o)
Thanks for your work,
Paolo