This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[fortran,patch] Fix PR 25252, error-recovery and ice-on-invalid
- From: FX Coudert <fxcoudert at gmail dot com>
- To: "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, gcc-patches list <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 17 Nov 2007 16:33:44 +0000
- Subject: [fortran,patch] Fix PR 25252, error-recovery and ice-on-invalid
Attached patch fixes PR 25252, which is in fact two error-recovery
and ice-on-invalid bugs in gfc_match_modproc(), the function that
matches module procedure statements. The first part is to move the
check for syntax error earlier in the loop. The second part is the
recovery part: when we have a syntax error after having succesfully
emitted code for some symbols (like "module procedure foo, bar, not
=> allowed"), we used to no remove the already created symbols (foo
and bar) from the interface, even though the symbols will be cleaned
up in reject_statement(). Thus, the interface's sym-
>interface.generic (if it's a generic interface, e.g.) was left with
pointers to cleaned up memory. I counter this by resetting the
interface to its previous state (creating two auxiliary functions in
interface.c to help), and freeing the allocated gfc_interface's.
Bootstrapped and regtested on x86_64-linux, OK to commit?
FX
:ADDPATCH fortran:
Attachment:
pr25252.ChangeLog
Description: Binary data
Attachment:
pr25252.diff
Description: Binary data