This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)

From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
To: FX Coudert <fxcoudert at gmail dot com>
Cc: "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, gcc-patches list <gcc-patches at gcc dot gnu dot org>
Date: Sat, 17 Nov 2007 14:22:42 +0100
Subject: Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
References: <26954C8E-C987-4CD4-9887-310B6D00F004@gmail.com> <4735D4C2.6050102@physik.uni-muenchen.de> <F7B8D403-B274-4E0A-AF60-29ED89CAB022@gmail.com> <473E7F1E.6010503@physik.uni-muenchen.de>

Tobias Schlüter wrote:

The updated patch looks ok.

Sorry, that I didn't think of this earlier. If you haven't committed the patch yet, and since you're touching it, can you please change the code to traverse the common tree in left-to-right order in order to prevent spurious differences between module files? Note that there's an early return in write_common0, so you have to be a bit careful.

Thanks,
- Tobi

Follow-Ups:
- Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
  - From: FX Coudert

References:
- [fortran,patch] Don't write common more than once in a module file (PR 30285)
  - From: FX Coudert
- Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
  - From: Tobias Schlüter
- Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
  - From: FX Coudert
- Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
  - From: Tobias Schlüter

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]