This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[objc] testsuite set of -I


Hi folks.

Is there any reason why we set -I only if we have built libobjc?  This
doesn't make sense.  This just means we won't be able to test compile
only tests (with include files) unless libobjc is built.

I'm running into this while building tuples.  I have a working objc
compiler, but not libobjc because our tuples->RTL pass is not working
yet, so I can't test even compile tests without this patch.

Is this OK for mainline after it re-opens?

Aldy

=== obj-c++.exp
==================================================================
--- obj-c++.exp	(revision 130048)
+++ obj-c++.exp	(local)
@@ -317,10 +317,8 @@
 	}
     }
 
-    if { $libobjc_dir != "" } {
-	set objc_include_dir "${srcdir}/../../libobjc"
-	lappend options "additional_flags=-I${objc_include_dir}"
-    }
+    set objc_include_dir "${srcdir}/../../libobjc"
+    lappend options "additional_flags=-I${objc_include_dir}"
 
     lappend options "additional_flags=[libio_include_flags]"
     lappend options "compiler=$OBJCXX_UNDER_TEST";
=== objc.exp
==================================================================
--- objc.exp	(revision 130048)
+++ objc.exp	(local)
@@ -179,9 +179,9 @@
 	     [lookfor_file ${objcpath} libobjc/.libs/libobjc-gnu.${shlib_ext}]
 	}
     }
+    set objc_include_dir "${srcdir}/../../libobjc"
+    lappend options "additional_flags=-I${objc_include_dir}"
     if { $libobjc_dir != "" } {
-	set objc_include_dir "${srcdir}/../../libobjc"
-	lappend options "additional_flags=-I${objc_include_dir}"
 	set libobjc_dir [file dirname ${libobjc_dir}]
 	set objc_link_flags "-L${libobjc_dir}"
 	lappend options "additional_flags=${objc_link_flags}"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]