This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: stabilize java assertion tables
Andrew Haley writes:
> Alexandre Oliva writes:
> > Using TYPE_UID rather than pointers to hash type_assertions shaved off
> > another 70 -fvar-tracking-assignments (and, probably -g vs -g0)
> > codegen differences. Now I'm down to four differences on
> > x86_64-linux-gnu libs, yay.
> >
> > Ok for trunk, after retesting in it (rather than in the vta branch)
> > completes?
> >
> > for gcc/ChangeLog.vta => gcc/java/ChangeLog
> > from Alexandre Oliva <aoliva@redhat.com>
> >
> > * java/expr.c (type_assertion_hash): Hash type uids rather
> > than tree pointers.
> >
>
> I guess so. I don't understand that fragment of code at all, but I'll
> trust you.
Actually, that's a terrible thing for a maintainer to say. Blame a
lack of coffee.
If the assertion code is JV_ASSERT_TYPES_COMPATIBLE, we hash both op1
and op2; if it's JV_ASSERT_IS_INSTANTIABLE we only hash op1. And the
switch statement with multiple fall-throughs is the best way to do
this. OK.
Andrew.