This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] Fix decltype PRs

On 11/5/07, Paolo Carlini <pcarlini@suse.de> wrote:
> Hi Doug,
>
> a minor nit... Maybe the check:
>
> +  if (expr == error_mark_node || !expr || TREE_TYPE (expr) ==
> error_mark_node)
> +    return error_mark_node;
>
> could be
>
> +  if (!expr || error_operand_p (expr))
> +    return error_mark_node;

I didn't know about error_operand_p :)

But yes, that's better.

  - Doug
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]