This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] Fix lookup in typedefs of the currently open class (PR c++/33516)

Jakub Jelinek wrote: 
if (COMPLETE_TYPE_P (t))
  return true;

shortcut in currently_open_class breaks bootstrap.

That's backwards, should return false for complete types.

If I instead stick
gcc_assert (!COMPLETE_TYPE_P (t)) where currently_open_class is about to
return true, I get:

#0 fancy_abort (file=0xc55154 "../../gcc/cp/class.c", line=5617, function=0xc56750 "currently_open_class")
>[...] 
so something clearly relies on currently_open_class returning true
even for already completed classes.

That's odd. Ah well, I guess put the COMPLETE_TYPE_P check back where you had it then. Pre-approved.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]