This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++, diagnostic] PR 33495


Paolo Carlini <pcarlini@suse.de> writes:

| Hi all, hi Gaby,
| 
| I'm trying to make progress on this PR, taking also into account Jakub'
| comment in the audit trail about the unbounded size of statements.
| Currently I have the below, which passes regtesting on x86_64-linux,
| makes sense to you?

If we had `diagnostics with carret', we would just point to the locus
of the error.  Currently, we don't.  Just printing the statement would
not be good either -- because the internal representation does not
always accurately reflect the source code.  So, yes you're is OK if
you changed

| +       pp_cxx_identifier (cxx_pp, "<expression>");


to

 +       pp_cxx_identifier (cxx_pp, "<statement>");

Thanks!

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]