This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix lookup in typedefs of the currently open class (PR c++/33516)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 01 Nov 2007 14:53:00 -0400
Subject: Re: [C++ PATCH] Fix lookup in typedefs of the currently open class (PR c++/33516)
References: <20071031205735.GT5451@devserv.devel.redhat.com>

Jakub Jelinek wrote:

+	  if (!COMPLETE_TYPE_P (new_scope)
+	      && TYPE_MAIN_VARIANT (new_scope) != new_scope
+	      && currently_open_class (new_scope))
+	    new_scope = TYPE_MAIN_VARIANT (new_scope);

It seems unnecessary to have so many tests. Specifically the second test doesn't do anything. And I might move the !COMPLETE_TYPE_P test inside currently_open_class.

Jason

Follow-Ups:
- Re: [C++ PATCH] Fix lookup in typedefs of the currently open class (PR c++/33516)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]