This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] Fix aliasing warnings for typeid (PR c++/32260)

On Thu, Nov 01, 2007 at 02:59:55PM +0100, Richard Guenther wrote:
> Or
> 
> +  if (! TYPE_ALIAS_SET_KNOWN_P (pseudo_type_info))
> +    {
> +      tree type_info_type = TYPE_MAIN_VARIANT (const_type_info_type_node);
> +      TYPE_ALIAS_SET (pseudo_type_info) = get_alias_set (type_info_type);
> +    }
>    else
>       gcc_assert (TYPE_ALIAS_SET (pseudo_type_info) == get_alias_set
> (type_info_type));
> 
> I think it's worth it for checking purposes.

Yeah, adding such gcc_assert is a good idea.
So, is the patch ok with addition of the else gcc_assert (...)?

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]