This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add comment to sparseset.h about uninitialized data

From: Paolo Bonzini <bonzini at gnu dot org>
To: Peter Bergner <bergner at vnet dot ibm dot com>
Cc: janis187 at us dot ibm dot com, gcc-patches at gcc dot gnu dot org, Kenneth Zadeck <zadeck at naturalbridge dot com>
Date: Wed, 31 Oct 2007 14:32:02 +0100
Subject: Re: [PATCH] add comment to sparseset.h about uninitialized data
References: <1193785776.9717.20.camel@janis-laptop> <1193791703.7128.151.camel@otta> <1193793727.7128.164.camel@otta>

Note that even though I wrote sparseset.[hc] and the only use of
it is within the register allocator, I'm not sure whether I can
approve either patch...although, I guess the comment patch can
be considered obvious.

I would prefer to add a valgrind annotation, though that would work only if --enable-checking=valgrind is active.

Paolo

References:
- [PATCH] add comment to sparseset.h about uninitialized data
  - From: Janis Johnson
- Re: [PATCH] add comment to sparseset.h about uninitialized data
  - From: Peter Bergner
- Re: [PATCH] add comment to sparseset.h about uninitialized data
  - From: Peter Bergner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]