This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] initialize sparse sets with xcalloc

From: Janis Johnson <janis187 at us dot ibm dot com>
To: Andrew Pinski <pinskia at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 30 Oct 2007 16:27:25 -0700
Subject: Re: [PATCH] initialize sparse sets with xcalloc
References: <1193782766.9717.17.camel@janis-laptop> <de8d50360710301523l2e617eaaue3d769fadf5738ff@mail.gmail.com>
Reply-to: janis187 at us dot ibm dot com

On Tue, 2007-10-30 at 15:23 -0700, Andrew Pinski wrote:
> On 10/30/07, Janis Johnson <janis187@us.ibm.com> wrote:
> > For mainline cc1 with the testcase in PR33635 with -O1, valgrind reports
> > use of uninitialized values in global_conflices at sparseset.h:90.
> > I don't have a test case where it makes a difference, but this patch
> > stops the complaint from valgrind.  Tested on powerpc64-linux, ok for
> > mainline?  (It's quite possible there's a better fix for this.)
> 
> This was PR 33796 but I think you need to read it fully since it was
> declared as invalid.

Thanks for the pointer, I withdraw this patch.  I submitted one to
add a comment in sparseset.h.

Janis

References:
- [PATCH] initialize sparse sets with xcalloc
  - From: Janis Johnson
- Re: [PATCH] initialize sparse sets with xcalloc
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]