This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,SH] Add SH2A new instructions 2/6
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: naveen dot hs at kpitcummins dot com
- Cc: gcc-patches at gcc dot gnu dot org, Anil dot Paranjape at kpitcummins dot com, Prafulla dot Thakare at kpitcummins dot com
- Date: Tue, 30 Oct 2007 08:39:27 +0900 (JST)
- Subject: Re: [PATCH,SH] Add SH2A new instructions 2/6
- References: <7B5265FF85A78C4BB9DAD0EE699C47600336E799@sohm.kpit.com>
"Naveen H.S." <naveen.hs@kpitcummins.com> wrote:
> Please find attached the modified patch "sh2a2.patch" as per the
> suggestions. This patch implements new instruction MOVI20S for SH2A
> target.
Looks fine, except for a few problems about coding standard.
Re-post the revised patch when the trunk returns to stage1.
Don't forget to describe how the patch is tested then.
> --- gcc-4.3-20070921/gcc/testsuite/gcc.target/sh/sh2a-movi20s.c 1970-01-01 05:30:00.000000000 +0530
> +++ tars/gcc-4.3-20070921/gcc/testsuite/gcc.target/sh/sh2a-movi20s.c 2007-10-24 12:08:08.000000000 +0530
> @@ -0,0 +1,18 @@
> +/* Testcase to check generation of a SH2A specific instruction for
> + "MOVI20S #imm20, Rn" */
Missing period.
> +/* { dg-skip-if "" { "sh*-*-*" } "*" "-m2a -m2a-nofpu -m2a-single
> + -m2a-single-only" } */
A single line would be safer.
> 2007-10-25 Jayant Sonar <Jayant.sonar@kpitcummins.com>
>
> * config/sh/constraints.md (I28): New.
> * config/sh/sh.c (broken_move): Add the condition for I28
> values.
> * config/sh/sh.md (movsi_ie): Add new instruction MOVI20S.
Should be
200z-xx-yy Jayant Sonar <Jayant.sonar@kpitcummins.com>
* config/sh/constraints.md (I28): New constraint.
* config/sh/sh.c (broken_move): Add support for movi20s.
* config/sh/sh.md (movsi_ie): Add the alternative for
movi20s.
New testcase requires an entry in gcc/testsuite/ChangeLog.
Regards,
kaz