Re: [PATCH] Cost of inlining when the function has call to a target-specific builtin

["Pranav Bhandarkar" <pranav dot bhandarkar at gmail dot com>]

Hi,

Really sorry for some confusion on my part. When I said,
> > I did a quick scan through a few backends and didnt find non-negigible
> > call cost target specific builtins.
I am sorry I meant size costs here.

> I think it is good enough for now given your quick scan.  That is,
> I'd propose to add a new weight in the eni_weights structure for
> target builtins and use that. Given that your patch doesn't introduce
> sophisticated use of the target hook in any target and we're in stage3
> already.

Thanks. I am attaching a patch. I have added a new field to the
eni_weights structure and initialized it in init_inline_once (). For
the size weight I have initialized it to 1 and for the time weight I
have initialized it to 10 at present since there is no data to back
any other value and also It would not change behaviour for most
backends now that we are in stage 3. For the inlining weight too, I
have initialized it to 1.

Is this ok ?

Thanks,
Pranav

2007-09-22  Pranav Bhandarkar  <pranav.bhandarkar@celunite.com>
            Ramana Radhakrishnan  <ramana@hercules.pun.celunite.com>
	
	* tree-inline.h (eni_weights): Add field target_builtin_cost to
	reflect the cost per call to a target specific builtin.
	* tree-inline.c (estimate_num_insns_1): If it is a CALL_EXPR for a
	call to a target specific builtin, then use target_builtin_call_cost.
	(init_inline_once): Initialize target_builtin_call_cost field.

Attachment: target_builtin_call_cost_patch
Description: Binary data