This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ PATCH] Fix FUNCTION_TYPE hashing problem (PR c++/33506)

Jakub Jelinek wrote:
BTW, aren't there many other things type_hash_eq doesn't check?

Assuming it is ok if it changes TYPE_UID aka TYPE_HASH and
TYPE_MAIN_VARIANT, I don't see it checking e.g.:
1) common.base.*_flag* (TYPE_VOLATILE, ...)

These are handled specially by walking the list of variants; the hash table only contains main variants.

2) TYPE_SIZE, TYPE_SIZE_UNIT
3) *_flag
4) TYPE_NAME

etc.? What exactly we can tolerate to change?

I think anything that doesn't change the type from the language's perspective. Exception specs are part of the C++ type; the name of a typedef is not.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]