This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix FUNCTION_TYPE hashing problem (PR c++/33506)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 20 Sep 2007 18:50:43 -0400
- Subject: Re: [C++ PATCH] Fix FUNCTION_TYPE hashing problem (PR c++/33506)
- References: <20070920000103.GB2625@devserv.devel.redhat.com> <46F2EB64.90103@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Sep 20, 2007 at 05:51:32PM -0400, Mark Mitchell wrote:
> I think you have the right idea with a hook, but I don't think it's in
> the right place. In particular, decl_attributes should be taught not to
> corrupt the type in this way. Instead, I think type_hash_eq should have
> a language hook to allow the C++ front end to say that for a
> FUNCTION_TYPE the TYPE_RAISES_EXCEPTION matters for equality.
Ok, will try that tomorrow.
BTW, aren't there many other things type_hash_eq doesn't check?
Assuming it is ok if it changes TYPE_UID aka TYPE_HASH and
TYPE_MAIN_VARIANT, I don't see it checking e.g.:
1) common.base.*_flag* (TYPE_VOLATILE, ...)
2) TYPE_SIZE, TYPE_SIZE_UNIT
3) *_flag
4) TYPE_NAME
etc.? What exactly we can tolerate to change?
Jakub