This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: New warning option -Walloca


> Keeping warn_disallowed_function_p() in opts.c (instead of
> c-common.c), and handling this new option in opts.c (instead of
> c-opts.c) makes the code a lot cleaner. This is because all this new
> code shares some common definitions (DEF_VEC_P of char_p), and
> functions (the refactored add_comma_separated_to_vector() function)
> with the -finstrument-functions-exclude* handling code in opts.c
>
> But if you feel strongly about moving warn_disallowed_function_p() to
> c-common.c, and handling the option in c-opts.c, I will make the
> changes you suggested.
>

I see now why it could be less cleaner and I don't have a good
solution for that. Then, you shouldn't move the option definition to
c.opt either.

Cheers,

Manuel.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]