This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Fix PR 32915 dllimport regression
- From: Danny Smith <dannysmith at clear dot net dot nz>
- To: 'François-Xavier Coudert' <fxcoudert at gmail dot com>
- Cc: 'gcc-patches' <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 12 Sep 2007 22:08:29 +1200
- Subject: RE: [PATCH] Fix PR 32915 dllimport regression
> From: François-Xavier Coudert
> Sent: Wednesday, 12 September 2007 4:43 a.m.
>
> > Thanks for the clarification. I wasn't sure whether my authority
> > extended to such parts of files like i386.[ch].
>
> ping?
I'm not 100% that my patch is "the right thing" . Shouldn't
decl_assembler_name_equal
test for a NULL_TREE (or at least gcc_assert (decl_asmname !=
NULL_TREE))?
Danny
Index: tree.c
===================================================================
*** tree.c (revision 128359)
--- tree.c (working copy)
*************** decl_assembler_name_equal (tree decl, tr
*** 312,317 ****
--- 312,320 ----
{
tree decl_asmname = DECL_ASSEMBLER_NAME (decl);
+ if (decl_asmname == NULL_TREE)
+ return false;
+
if (decl_asmname == asmname)
return true;
>
> FX
>