This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][4.2] Fix PR33382, ICE in get_constraints_for_component_ref


Richard Guenther wrote:

> Bootstrapped and tested on i686-pc-linux-gnu.  Mark, what is the
> state of the 4.2 branch currently?

Thank you for asking.  It's slushy.

> 2007-09-11  Richard Guenther  <rguenther@suse.de>
> 
> 	PR middle-end/33382
> 	* tree-ssa-structalias.c (push_fields_onto_fieldstack): Make
> 	Accesses to a whole flexible array member may also lead to no
> 	subvariable.
> 
> 	* gcc.c-torture/compile/pr33382.c: New testcase.
> 	* gcc.c-torture/execute/pr33382.c: Likewise.

This is OK.  (I'm not worried about this even requiring another RC
build, since all you're doing is weakening an assert.)

However, the ChangeLog entry isn't quite grammatical.  Perhaps "Note
that accesses to a whole flexible array member may not lead to a
subvariable."?

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]