This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR32586, restore combining of conversions in SCCVN
- From: "Daniel Berlin" <dberlin at dberlin dot org>
- To: "Richard Guenther" <rguenther at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 6 Sep 2007 09:19:23 -0400
- Subject: Re: [PATCH] Fix PR32586, restore combining of conversions in SCCVN
- References: <Pine.LNX.4.64.0709061321220.4343@s68.fhfr.qr>
On 9/6/07, Richard Guenther <rguenther@suse.de> wrote:
>
> This fixes PR32586 (as I promised to do) and re-instantiates
> tree-combining of conversions in FRE/SCCVN. This allows to remove
> a bunch of XFAILs Danny added at SCCVN merge time. This also fixes
> the builtins-51.c failure on trunk.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu. Danny, are
> the SCCVN changes ok? (Is there a better way than value_expr_p?
> What I would need is a predicate that tells whether I can substitute
> VN_INFO -> expr for the value number in expressions)
has_constants can normally tell you whether you can substitute the
->expr in, but that was predicated on the idea that we only wanted to
substitute in constants.
If this is no longer true, i'm okay with value_expr_p for now.