This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: break MIPS16 TLS
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <richard at codesourcery dot com>
- Date: Wed, 5 Sep 2007 10:46:56 -0400
- Subject: Re: PATCH: break MIPS16 TLS
- References: <46DD508D.4090808@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Sep 04, 2007 at 08:33:17AM -0400, Sandra Loosemore wrote:
> Richard and I have previously been discussing this change in the context
> of the MIPS16 function attributes patch. Yesterday we had some internal
> discussion and realized we were talking about doing different things;
> so, for avoidance of ambiguity, this patch is my current understanding
> of the change Richard wants me to make. It's actually completely
> independent of the MIPS16 function attributes patch, so I've split it
> off for separate consideration.
>
> I'm still trying to figure out what to do with the testsuite, since this
> change intentionally breaks all the TLS tests with -mips16.
I don't see how this can be a good thing.
If the target can't support taking address of a __thread variable,
then it should IMNSHO use emutls.
Emutls was added so that all targets can support __thread and so that
code can assume it and use it portably. If MIPS16 has crippled __thread
support, then that's suddenly not true.
Jakub