This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Fortran, Patch] PR 33232 - Reject comma in "READ(...)," with -std=f95


Tobias Burnus wrote:
Tobias Schlüter wrote:
Tobias Burnus wrote:
read *, a ! valid
From looking over the code, I think this will break the second case
you mentioned.

Well, it does not. (I wondered myself, but as it did not break, I ignored it.) Thanks for being pedantic; I now remove the whole k == M_* check as comma_flag is what matters.

Thanks, I reread the code, and match_dt_format is where the asterisk is eaten, so all is fine.


Do we have any testcases for this?
I could find only the following:
gfortran.dg/vect/vect-1.f90:READ*, X, Y
gfortran.dg/vect/vect-2.f90:READ*, X, Y

which however does not test for
  READ '(format-string)', ...
and which are
  ! { dg-require-effective-target vect_float }
thus I added another test case.

Thanks.


Rebuild and check-gfortraned. Now ok for the trunk?

Yes, thanks, - Tobi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]