This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix hardcoded rs6000-xcoff csects alignment
- From: Olivier Hainque <hainque at adacore dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, hainque at adacore dot com
- Date: Fri, 31 Aug 2007 09:19:55 +0200
- Subject: Re: [PATCH] fix hardcoded rs6000-xcoff csects alignment
- References: <20070618105022.GA22955@cardhu.act-europe.fr> <200708130044.l7D0ihrP031148@makai.watson.ibm.com>
David Edelsohn wrote:
> * config/rs6000/xcoff.h (XCOFF_CSECT_DEFAULT_ALIGNMENT_STR): New
> internal macro. Default alignment factor for csect directives, chosen
> to match what BIGGEST_ALIGNMENT allows.
> (DATA_SECTION_ASM_OP): Use it.
> * config/rs6000/rs6000.c
> (rs6000_xcoff_output_readonly_section_asm_op):
> Use XCOFF_CSECT_DEFAULT_ALIGNMENT_STR.
> (rs6000_xcoff_output_readwrite_section_asm_op): Likewise.
> (rs6000_xcoff_output_toc_section_asm_op): Likewise.
>
> This is okay, except for the last change. The secondary TOC section
> contains pointers and currently aligns to the pointer size based on
> TARGET_32BIT. No need to align that csect more strictly than 64 bits, and
> especially not varying between 32 bits and 128 bits.
OK, revs 127956 for the source changes & 127957 for the testcase.
Thanks.