This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Solaris 10 fixincludes tweak


Bruce Korb wrote:

> Then perhaps that is the easiest thing:   make sure the upad64_t parts of
> the initializer are always just plain "0".  This is what I thought they were,
> actually, so it is again unclear to me why the initializer needs fixing at all.

If the initializer is plain zero, but the initialized entity is a union,
then with -W -Wall, you will get warnings about the brace structure of
the initializer not matching the type.

>> If you're not sanguine about my patch, though, and you're willing to do
>> the infrastructure work, I'll try to fill it in as you suggest.
> 
> I'm confident enough that this will fix it for now.  The issue is, "Will it need
> fixing again?"  History says, "Yes."  I'm thinking maybe it has been fixed
> enough times already.  :)

Are you still up for trying to do the C bits to do the abstractly more
correct fix?  (No pressure; I'm not suggesting you have any obligation.)
 If so, I'll wait for that.  Otherwise, I'm not going to have time to do
that myself, so we can either accept my hack-of-a-patch, or just punt.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]