Re: [patch] Make OMP expansion work on SSA form

[Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>]

Hello,

> On 8/20/07 11:02 AM, Zdenek Dvorak wrote:
> 
> > One other change is that on the branch, we do the expansion of OMP
> > constructs in SSA form when optimizing, so that the SSA form expansion
> > code is tested; this patch does the expansion always without SSA form
> > (unless you use newly introduced -fopenmp-ssa switch).  This is forced
> > by some pass ordering problems (early optimization passes would not be
> > run on the split functions if the expansion were done on SSA form).
> 
> I don't like this.  A new switch for doing OpenMP expansion in SSA form?
>  Too confusing.  I realize that we need to expand OpenMP constructs in
> SSA form and without SSA form (for -O0), but we should do this
> automatically, not with a switch.

by default, the expansion is always done without ssa form, for the reasons I
explained.  I kept the possibility to force the expansion on ssa form
for testing purposes; I guess I can remove the switch, but I would
prefer to keep it at least for some time.

Zdenek

> I'm reviewing the rest of the patch.  More feedback soon.