This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Unwind_Backtrace for ARM EABI
- From: Andrew Haley <aph-gcc at littlepinkcloud dot COM>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 29 Aug 2007 10:45:49 +0100
- Subject: Re: RFA: Unwind_Backtrace for ARM EABI
- References: <m34piiiv1g.fsf@redhat.com>
Nick Clifton writes:
> Hi Andrew,
>
> > As discussed, this implements the missing Unwind_Backtrace for ARM
> > EABI.
>
> Was the code tested ? If so, how ?
Extensively with the libgcj testsuite. Java uses backtraces a lot, so
this gives Unwind_Backtrace a thorough workout.
> > OK for trunk?
>
> Approved, but I would recommend one small change: You could replace
> the "goto finish" statements with "break" and then drop the finish
> label altogether. Gotos being considered dangerous and all that...
Heh. Nanny! OK. ;-)
Andrew.