This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix c++/33194
- From: "Richard Guenther" <richard dot guenther at gmail dot com>
- To: "Doug Gregor" <doug dot gregor at gmail dot com>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 28 Aug 2007 23:49:30 +0200
- Subject: Re: [C++ PATCH] Fix c++/33194
- References: <24b520d20708281359o2b2cca9dgca343046a58a4545@mail.gmail.com>
On 8/28/07, Doug Gregor <doug.gregor@gmail.com> wrote:
> PR c++/33194 is a canonical-types failure and 4.3 regression stemming
> from a thinko in build_type_attribute_qual_variant. We were trying to
> set the canonical type before calling type_hash_canon, which means
> that the canonical type might end up being lost, and were not handling
> qualifiers correctly besides.
>
> The patch below fixes both issues. Tested i386-apple-darwin8.10.1; no
> regressions. Okay for mainline?
This is ok.
Thanks,
Richard.
> - Doug
>
> 2007-08-28 Douglas Gregor <doug.gregor@gmail.com>
>
> PR c++/33194
> * tree.c (build_type_attribute_qual_variant): Set canonical types
> on the final, unqualified attribute variant before building the
> qualified version.
>
> 2007-08-28 Douglas Gregor <doug.gregor@gmail.com>
>
> PR c++/33194
> * g++.dg/other/canon-33194.C: New.