This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix check_explicit_specialization (PR c++/32596, regression caused by PR c++/31923)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Mark Mitchell <mark at codesourcery dot com>, Simon Baldwin <simonb at google dot com>, "gcc-patches at gcc dot gnu dot org >> gcc-patches List" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 27 Aug 2007 11:56:38 -0400
Subject: Re: [C++ PATCH] Fix check_explicit_specialization (PR c++/32596, regression caused by PR c++/31923)
References: <20070615174708.E6C3141A0C0@localhost> <4672DF37.9000708@codesourcery.com> <4672EECA.5050400@google.com> <20070815184753.GS2063@devserv.devel.redhat.com>

Jakub Jelinek wrote:

The following patch copies just DECL_INTERFACE_KNOWN which is enough to fix
this bug and didn't cause any make check-g++ or make check-libstdc++-v3
failure, but I wonder if we shouldn't copy DECL_NOT_REALLY_EXTERN as well,
or if DECL_INTERFACE_KNOWN can be copied over unconditionally.

+	      if (! TREE_PUBLIC (decl) && DECL_INTERFACE_KNOWN (tmpl_func))
+		DECL_INTERFACE_KNOWN (decl) = 1;

The right fix is to do what grokfndecl does: if !TREE_PUBLIC, set DECL_INTERFACE_KNOWN and DECL_NOT_REALLY_EXTERN. No need to check DECL_INTERFACE_KNOWN on the template.

Incidentally, it seems wrong to me to be propagating DECL_VISIBILITY here, since a specialization can have less visibility than its template.

Jason

Follow-Ups:
- Re: [C++ PATCH] Fix check_explicit_specialization (PR c++/32596, regression caused by PR c++/31923)
  - From: Jakub Jelinek

References:
- [C++ PATCH] Fix check_explicit_specialization (PR c++/32596, regression caused by PR c++/31923)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]