This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Handel REG_LIBCALL note after split
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Sa Liu <SALIU at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 15 Aug 2007 08:16:42 -0400
- Subject: Re: [PATCH] Handel REG_LIBCALL note after split
- References: <OFDBB8991B.357E74CF-ONC1257330.0040277E-C1257332.004B48F3@de.ibm.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Aug 09, 2007 at 03:40:39PM +0200, Sa Liu wrote:
> This patch relink the insns with REG_LIBCALL note and with REG_RETVAL note
> after split.
> The discussion in GCC mailing list can be found here:
> http://gcc.gnu.org/ml/gcc/2007-07/msg00925.html
>
> The patch has been tested on spu with gcc test suits and got no
> regression.
> --- gcc.orig/emit-rtl.c
> +++ gcc/emit-rtl.c
> @@ -3264,6 +3264,16 @@ try_split (rtx pat, rtx trial, int last)
> }
> break;
> #endif
> + case REG_LIBCALL:
> + /* Relink the insns with REG_LIBCALL note and with REG_RETVAL note
>
> + after split. */
> + REG_NOTES (insn_last)
> + = gen_rtx_EXPR_LIST (REG_LIBCALL,
> + XEXP (note, 0),
> + REG_NOTES (insn_last));
> + note_retval = find_reg_note (XEXP (note, 0), REG_RETVAL, NULL);
> + XEXP (note_retval, 0) = insn_last;
> + break;
>
> default:
> break;
REG_LIBCALL is together with REG_RETVAL, REG_CC_SETTER, REG_CC_USER and
REG_LABEL supposed to use INSN_LIST rather than EXPR_LIST. In addition
to being printed wrongly in dumps this causes PR33074 regression.
Fixed thusly, committed as obvious:
2007-08-15 Jakub Jelinek <jakub@redhat.com>
PR middle-end/33074
* emit-rtl.c (try_split): Use INSN_LIST instead of EXPR_LIST for
REG_LIBCALL note.
* gfortran.dg/pr33074.f90: New test.
--- gcc/emit-rtl.c.jj 2007-08-13 15:11:18.000000000 +0200
+++ gcc/emit-rtl.c 2007-08-15 13:44:36.000000000 +0200
@@ -3274,7 +3274,7 @@ try_split (rtx pat, rtx trial, int last)
/* Relink the insns with REG_LIBCALL note and with REG_RETVAL note
after split. */
REG_NOTES (insn_last)
- = gen_rtx_EXPR_LIST (REG_LIBCALL,
+ = gen_rtx_INSN_LIST (REG_LIBCALL,
XEXP (note, 0),
REG_NOTES (insn_last));
--- gcc/testsuite/gfortran.dg/pr33074.f90.jj 2007-08-15 14:00:16.000000000 +0200
+++ gcc/testsuite/gfortran.dg/pr33074.f90 2007-08-15 13:58:57.000000000 +0200
@@ -0,0 +1,8 @@
+! PR middle-end/33074
+! { dg-do compile }
+! { dg-options "-O" }
+
+subroutine pr33074(a, w)
+ real a(1), w(1)
+ a(1) = 2.0**int(w(1))
+end
Jakub