This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ada PATCH INSTALLED]: constifications
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- To: ghazi at caip dot rutgers dot edu
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 11 Aug 2007 11:03:48 EDT
- Subject: Re: [Ada PATCH INSTALLED]: constifications
- References: <Pine.GSO.4.58.0708110945380.20555@caipclassic.rutgers.edu>
Thanks for doing this. Two minor issues:
> + const_tree const field1 = * (const_tree const*) rt1;
> + const_tree const field2 = * (const_tree const*) rt2;
Please fix the missing blank before the second "*".
> + const int ret = tree_int_cst_compare (bit_position (field1), bit_position (field2));
Isn't this line too long?
The same problems are in utils2.c.