This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR32987 - Allow TAB in FORMAT statements as extension and warn with -std=f*
Franc,ois-Xavier,
FX Coudert wrote:
>> + c = next_char_not_space (&error);
>> + if (error)
>> + return FMT_ERROR;
> We now have to perform a check after each next_char_not_space; this
> seems to me rather heavy (in term of code simplicity/readability) for
> such an extension. Maybe you can think a something that would be less
> heavy (a macro?).
As format_lex has only a single "return", I simply moved the "if
(error)" just before "return "token". Additionally, I initialize "error"
now once in format_lex and not every time in next_char_not_space which
should also save some ns.
http://gcc.gnu.org/viewcvs?view=rev&revision=127324
Thanks for the two patch reviews.
Tobias