This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Add a __nowarn__ keyword
On Wed, 8 Aug 2007, [ISO-8859-1] Manuel López-Ibáñez wrote:
> About the patch itself, I don't understand why you use one approach
> for the C parser and a different one for the C++ parser. I think it
> would be advantageous to use the same approach even if you cannot
> share the relevant functions. I prefer the cp_parser_nowarn_opt
> approach: the resulting code looks simpler.
In creating the __nowarn__ patch, I copied the mechanism each frontend
used for handling __extension__ and then tweeked it for the new keyword.
Each frontend had it's own way of doing __extension__. Since that code is
old (i.e. well tested), I don't want to change it gratuitously.
> Also, the patch needs testcases. And a follow-up for GCC 4.3 webpage
> if we want to expose this to users.
I was counting on my CONST_CAST patch to exercise the __nowarn__ keyword,
that way it's tested as part of bootstrapping. (There's precedence for
not adding testcases for bugs that are exposed through bootstrapping, I
figured feature tests are similar.) I didn't see any tests for
__extension__ either or I would have copied those. I can add more tests
as a followup, can you perhaps suggest some?
Thanks,
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu