This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] Fixed inconsistent iterator interface
- From: Diego Novillo <dnovillo at google dot com>
- To: Christopher Matthews <chrismatthews at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Aldy Hernandez <aldyh at redhat dot com>
- Date: Tue, 07 Aug 2007 18:46:07 -0400
- Subject: Re: [tuples] Fixed inconsistent iterator interface
- References: <5794c4c80708071533o3b1ae68bncd38d219e702afc0@mail.gmail.com>
On 8/7/07 6:33 PM, Christopher Matthews wrote:
> -static inline gimple_stmt_iterator
> +static inline gimple_stmt_iterator*
space before '*'.
> gsi_start (gimple_seq seq)
> {
> - gimple_stmt_iterator i;
> + gimple_stmt_iterator* i = ggc_alloc_cleared (sizeof (gimple_stmt_iterator));
^^^^^^^^^^^^^^^^^^^^^^^
gimple_stmt_iterator *i
> - gimple_stmt_iterator i;
> + gimple_stmt_iterator* ittr;
Why the new name? Was 'i' clashing with some other local?
> -extern void verify_gimple_1 (tree);
> +extern void verify_gimple_1 (gimple_seq);
This is for your next patch, me thinks.
> -/* Verify the GIMPLE statements inside the statement list STMTS. */
> +/* Verify the GIMPLE statements inside the sequence STMTS. */
> void
> -verify_gimple_1 (tree stmts)
> +verify_gimple_1 (gimple_seq stmts)
Likewise.
OK with those changes.