This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix i686-linux --enable-targets=all

On Mon, Aug 06, 2007 at 06:41:28AM -0700, H.J. Lu wrote:
> It is the part of
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31868
> 
> and a complete patch is posted at
> 
> http://gcc.gnu.org/ml/gcc-patches/2007-05/msg00563.html
> 
> Could someone please review it?

I see.  I don't think your patch actually handles this case; you set
CRTSTUFF_T_FLAGS in t-crtstuff64, but i386/t-crtstuff will be included
afterwards, and that will set it again.  That's why I did it more
centrally.  The problem is the same for any target that forces
creation of .eh_frame; my patch won't affect i386-linux crtend.o even
though it changes the compile flags there.

Also, I think += is preferred.

-- 
Daniel Jacobowitz
CodeSourcery
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]