Re: PATCH: PR testsuite/32932: ssp tests can't find libssp

[Janis Johnson <janis187 at us dot ibm dot com>]

On Tue, 2007-07-31 at 11:20 -0700, H.J. Lu wrote:
> On Tue, Jul 31, 2007 at 10:43:56AM -0700, Janis Johnson wrote:
> > On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote:
> > > This patch makes sure that the newly built libssp is used for
> > > test. Tested on Linux/x86-64.
> > 
> > The patch doesn't handle multilibs; apparently you didn't test
> > with both -m32 and -m64.
> 
> It does support multilibs:
> 
> @@ -113,6 +114,10 @@ proc gcc_init { args } {
>      set gcc_error_prefix "error:"
> 
>      gcc_maybe_build_wrapper "${tmpdir}/gcc-testglue.o"
> +
> +    libssp_init [get_multilibs]

But libssp_init only processes the first one; see how they're
handled for libmudflap, for example, to add all of them to
LD_LIBRARY_PATH.

> and I tested with -m32 on Linux/x86-64:
> 
> Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
>   -B/export/build/gnu/gcc/build-x86_64-linux/gcc/
>   /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column
>   -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs
>   -lm   -m32 -o ./ssp-1.exe    (timeout = 300)

This uses the 32-bit library for -m32, and adds it to LD_LIBRARY_PATH

> Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
>   -B/export/build/gnu/gcc/build-x86_64-linux/gcc/
>   /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c
>   -fstack-protector -fno-show-column
>   -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs
>   -lm   -o ./ssp-1.exe    (timeout = 300)

This uses the 32-bit library for the default and adds the 32-bit
library to LD_LIBRARY_PATH.

Janis