This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR testsuite/32932: ssp tests can't find libssp
- From: "H.J. Lu" <hjl at lucon dot org>
- To: Janis Johnson <janis187 at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, echristo at apple dot com
- Date: Tue, 31 Jul 2007 11:20:01 -0700
- Subject: Re: PATCH: PR testsuite/32932: ssp tests can't find libssp
- References: <20070730230359.GA13062@lucon.org> <1185903836.6581.15.camel@janis-laptop>
On Tue, Jul 31, 2007 at 10:43:56AM -0700, Janis Johnson wrote:
> On Mon, 2007-07-30 at 16:03 -0700, H.J. Lu wrote:
> > This patch makes sure that the newly built libssp is used for
> > test. Tested on Linux/x86-64.
>
> The patch doesn't handle multilibs; apparently you didn't test
> with both -m32 and -m64.
It does support multilibs:
@@ -113,6 +114,10 @@ proc gcc_init { args } {
set gcc_error_prefix "error:"
gcc_maybe_build_wrapper "${tmpdir}/gcc-testglue.o"
+
+ libssp_init [get_multilibs]
+
+ set gcc_initialized 1
}
#
and I tested with -m32 on Linux/x86-64:
Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs
-lm -m32 -o ./ssp-1.exe (timeout = 300)
PASS: gcc.dg/ssp-1.c (test for excess errors)
Setting LD_LIBRARY_PATH to :/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs::/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libstdc++-v3/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libmudflap/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libgomp/.libs:/export/build/gnu/gcc/build-x86_64-linux/./gcc:/export/build/gnu/gcc/build-x86_64-linux/./prev-gcc
PASS: gcc.dg/ssp-1.c execution test
...
Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc -B/export/build/gnu/gcc/build-x86_64-linux/gcc/ /export/gnu/src/gcc/gcc/gcc/testsuite/gcc.dg/ssp-1.c -fstack-protector -fno-show-column -L/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs
-lm -o ./ssp-1.exe (timeout = 300)
PASS: gcc.dg/ssp-1.c (test for excess errors)
Setting LD_LIBRARY_PATH to :/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs::/export/build/gnu/gcc/build-x86_64-linux/gcc:/export/build/gnu/gcc/build-x86_64-linux/gcc/32:.:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/32/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libstdc++-v3/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libmudflap/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libssp/.libs:/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libgomp/.libs:/export/build/gnu/gcc/build-x86_64-linux/./gcc:/export/build/gnu/gcc/build-x86_64-linux/./prev-gcc
PASS: gcc.dg/ssp-1.c execution test
>
> These tests really ought to be in libssp/testsuite, which doesn't
> yet exist, and look for libraries in the same way as other library
> testsuites. I've copied Eric Christopher, who added these tests,
> to get his opinion about that.
>
> Setting gcc_initialized doesn't belong in this patch, and should
> be tested by running the full testsuite with multiple runs, e.g.
> -m32 and -m64, to make sure there are no surprises.
Here is my result:
http://gcc.gnu.org/ml/gcc-testresults/2007-07/msg01202.html
H.J.