This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFA: Handle unsigned characters from string constants in store-ccp

From: Daniel Jacobowitz <drow at false dot org>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: Diego Novillo <dnovillo at google dot com>, gcc-patches at gcc dot gnu dot org
Date: Wed, 25 Jul 2007 07:21:09 -0400
Subject: Re: RFA: Handle unsigned characters from string constants in store-ccp
References: <20070724170038.GA13387@caradoc.them.org> <46A64D75.3060901@google.com> <84fc9c000707241330m4c5f1e11t30fbea8c6c141633@mail.gmail.com>

On Tue, Jul 24, 2007 at 10:30:50PM +0200, Richard Guenther wrote:
> On 7/24/07, Diego Novillo <dnovillo@google.com> wrote:
> > On 7/24/07 1:00 PM, Daniel Jacobowitz wrote:
> >
> > > Is this patch OK?
> >
> > Yes.
> 
> No, you should use build_int_cst_type (TREE_TYPE (t), (unsigned
> char)...) instead.  (Definitely not use build_int_cst with a NULL type
> argument)

Sorry, I'd already committed it.  Should the place this code is based
on change too?  That's fold-convert.c:fold_read_from_constant_string.

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: RFA: Handle unsigned characters from string constants in store-ccp
  - From: Richard Guenther

References:
- RFA: Handle unsigned characters from string constants in store-ccp
  - From: Daniel Jacobowitz
- Re: RFA: Handle unsigned characters from string constants in store-ccp
  - From: Diego Novillo
- Re: RFA: Handle unsigned characters from string constants in store-ccp
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]