This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] fix gimplify_return_expr buglet
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Diego Novillo <dnovillo at google dot com>
- Cc: amacleod at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 20 Jul 2007 15:31:20 -0400
- Subject: Re: [tuples] fix gimplify_return_expr buglet
- References: <20070720174814.GA20788@redhat.com> <46A10A1E.3090006@google.com>
> I think we are still mis-gimplifying this. The operand we return should
> never be a MODIFY_EXPR. I don't remember if we've fixed this yet but I
> think not.
What do you mean?
My patch fixes the case of an empty return statement:
if (blah)
return;
I checked, and even stuff like:
if (a > 3)
return 69;
...is being generated correctly. We make a GIMPLE_ASSIGN tuple and set
everything up correctly. What testcase did you have in mind?
Aldy