This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tuples] declare_vars changes
- From: Diego Novillo <dnovillo at google dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: amacleod at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 18 Jul 2007 17:58:30 -0400
- Subject: Re: [tuples] declare_vars changes
- References: <20070718160525.GA13425@redhat.com>
On 7/18/07 12:05 PM, Aldy Hernandez wrote:
> First, I am grabbing what used to be BIND_EXPR_BLOCK from gimple_base,
> which has a block field. Is this correct?
>
> - block = BIND_EXPR_BLOCK (scope);
> + block = GIMPLE_BLOCK (scope);
Yup. That looks fine.
> Second, there is a call to declare_vars from within gimple_add_tmp_var
> which looked dubious to me (see FIXME). It was calling declare_vars
> when we didn't have a gimplify context and we didn't have cfun set. I
> couldn't think of any case where that might be true, and I did a full
> bootstrap of (C/C++) and didn't trigger it once. Is this used in any of
> the other languages, or in some weird context I haven't thought of?
> Just curious...
That's for nested functions. We need to expose the locals they create.