This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Fix diagnostic printing of AGGR_INIT_EXPR (PR c++/30854)
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 11 Jul 2007 08:49:56 -0500
- Subject: Re: [C++ PATCH] Fix diagnostic printing of AGGR_INIT_EXPR (PR c++/30854)
- References: <20070704112440.GS7012@devserv.devel.redhat.com>
Jakub Jelinek <jakub@redhat.com> writes:
| Hi!
|
| Before http://gcc.gnu.org/ml/gcc-patches/2007-02/msg01267.html
| AGGR_INIT_EXPR arguments were dumped in error.c through:
| pp_cxx_left_paren (cxx_pp);
| if (TREE_OPERAND (t, 1))
| dump_expr_list (TREE_CHAIN (TREE_OPERAND (t, 1)), flags);
| pp_cxx_right_paren (cxx_pp);
| i.e. the first operand (instance pointer) was always skipped.
| But now it is never skipped.
| The following patch fixes this (tested on x86_64-linux), though
| perhaps it might be better idea to just remove that argument
| from dump_aggr_init_expr_args altogether and just hardcode
| skipping of the first argument in that function. dump_aggr_init_expr_args
| has just one caller and is static function...
|
| Ok for trunk (or ok with removing the skipfirst argument)?
Yes, OK.
Thanks.
-- Gaby