This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR tree-optimization/32589

From: Eric Botcazou <ebotcazou at adacore dot com>
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 10 Jul 2007 22:15:16 +0200
Subject: Re: [PATCH] Fix PR tree-optimization/32589
References: <200707101113.56678.ebotcazou@adacore.com> <200707101543.49651.ebotcazou@adacore.com> <84fc9c000707100645k1a03b4f6ne1a3b15ddf9588e0@mail.gmail.com>

> I like this a lot better though would suggest valid_gimple_rhs_p for the
> name (or is_valid_gimple_rhs).

On second thoughts, you're right, the "after_folding" can be dropped, the 
predicate will correctly work in most circumstances.

However is_valid_gimple_rhs is not quite correct because the predicate rejects 
most lvalues, which are on the contrary accepted by is_gimple_formal_tmp_rhs.

So I think that valid_gimple_expression_p would be more appropriate.

-- 
Eric Botcazou

References:
- [PATCH] Fix PR tree-optimization/32589
  - From: Eric Botcazou
- Re: [PATCH] Fix PR tree-optimization/32589
  - From: Eric Botcazou
- Re: [PATCH] Fix PR tree-optimization/32589
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]